Solve 2022 day 02 #13

katzuv · 2022-12-09T22:30:32Z

No description provided.

YoniKF

Commented on part 1, where do I see the problem definition for part 2?

puzzles/solutions/2022/d02/p1.py

YoniKF · 2022-12-10T09:21:14Z

puzzles/solutions/2022/d02/p1.py

+def get_moves(input_text: str) -> list[tuple[str, str]]:
+    """
+    :param input_text: puzzle input
+    :return: list of (opponent move, our move) couples


Use the term "pair" instead of "couple".

Fixed in 583c923.

Do the same for all other places "couple" is used.

Did I miss any in that day's solutions?

YoniKF · 2022-12-10T09:31:50Z

puzzles/solutions/2022/d02/shapes.py

+OPPONENT_PAPER = "B"
+OPPONENT_SCISSORS = "C"
+
+OUR_TO_OPPONENT_SHAPE_DEFEAT = {


The different dictionaries here have different logical levels of abstractions.
The first two tell you what is the defeating shape, i.e., it is in the level of the general rock-paper-scissors game.
The third one tells you what input characters are the same shape, i.e., it is in the level of the definition of the problem's input -- not actually related to the game.
The fourth one tells you what the score is for each shape, i.e., it is in the level of the rock-paper-scissors tournament -- one level above the general game. Additional inconsistency is that some scores are defined here as a constant, and others are defined in the code itself.

I suggest you separate the levels of abstraction more clearly:

First, parse the problem input into some object describing the rock-paper-scissors game. Note that you don't really need to continue with the "our" and "opponent" shape distinction: If you represent a turn as a pair of shapes (our, opponent), you can use the same object for "our" and for "opponent" rock.

Define a function which reports the result of the turn, at the level of the rock-paper-scissors game -- So nothing about scores yet. This function can be a dictionary with all possible turns as keys are the corresponding values representing the result in some way.

Define a function which reports the score of the turn, at the level of the rock-paper-scissors tournament, based on the turn pair (from step 1) and the turn's result (from step 2).

katzuv · 2022-12-10T09:55:04Z

Commented on part 1, where do I see the problem definition for part 2?

It unlocks after solving part 1, so I'll paste it here:

The Elf finishes helping with the tent and sneaks back over to you. "Anyway, the second column says how the round needs to end: X means you need to lose, Y means you need to end the round in a draw, and Z means you need to win. Good luck!"

The total score is still calculated in the same way, but now you need to figure out what shape to choose so the round ends as indicated. The example above now goes like this:

In the first round, your opponent will choose Rock (A), and you need the round to end in a draw (Y), so you also choose Rock. This gives you a score of 1 + 3 = 4.

In the second round, your opponent will choose Paper (B), and you choose Rock so you lose (X) with a score of 1 + 0 = 1.

In the third round, you will defeat your opponent's Scissors with Rock for a score of 1 + 6 = 7.

Now that you're correctly decrypting the ultra top secret strategy guide, you would get a total score of 12.

Following the Elf's instructions for the second column, what would your total score be if everything goes exactly according to your strategy guide?

YoniKF · 2022-12-10T12:19:31Z

puzzles/solutions/2022/d02/p2.py

+import shapes
+
+
+DEFEAT = "X"


Kinda lousy that you have a shapes modules for constants, where you define OUR_ROCK = "X", but also define DEFEAT = "X" here.

YoniKF · 2022-12-10T12:20:45Z

puzzles/solutions/2022/d02/p2.py

+    if outcome == DEFEAT:
+        return shapes.OPPONENT_TO_OUR_SHAPE_DEFEAT[opponent_move]
+    if outcome == DRAW:
+        for our_shape, opponent_shape in shapes.IDENTICAL_SHAPES.items():


This for-loop means that you should have an inverted version of the IDENTICAL_SHAPES dictionary.

Previously the function gave the desired shape as if the given shape was ours and not the opponent's.

katzuv · 2022-12-10T19:48:41Z

I made quite a few changes, see what you think now.
About

This for-loop means that you should have an inverted version of the IDENTICAL_SHAPES dictionary.

I decided to leave a for-loop in choose_shape so to not have three different inverted dictionaries.

This module contains now more constants than just shapes, so a name change is desired.

katzuv added the solution Puzzle solution label Dec 9, 2022

katzuv self-assigned this Dec 9, 2022

katzuv marked this pull request as ready for review December 10, 2022 00:05

katzuv requested a review from YoniKF December 10, 2022 08:52

YoniKF reviewed Dec 10, 2022

View reviewed changes

katzuv force-pushed the solve/2022-02 branch from 583c923 to 1195c53 Compare December 10, 2022 16:27

katzuv added 22 commits December 10, 2022 20:50

Create solution file for part 1

4f502d4

Add function that parses the input

717483c

Create Python module for shapes constants

f03f539

Add constants for the shapes

1441ba3

Add dictionary that maps what opponent's shape is defeated by our shape

7425b50

Add dictionary that maps what shapes are identical

f71763d

Add dictionary that maps shapes to their respective scores

0450409

Add function that calculates a move's score

74025e4

Add function that calculates total score

0a70508

Create solution file for part 2

334cbab

Add constants for letters and outcomes

5c22100

Add dictionary that maps what opponent's shape defeats our shape

661570b

Add function that returns what shape should be played

30d3678

Add function that generate moves based on opponent moves and outcomes

6f652cb

Add function that calculates total score

76578a1

Return tuples instead of lists

7ac5567

Replace "couple" vs "pair"

0bbe1de

Remove wrong word

de7da71

Remove "our" from shapes names

ed1911f

Move identical shapes list up and update names

9de1b77

Normalize input and use generic-shapes instead of player-specific

2c84a14

Refactor winning moves mapping

319fa59

katzuv added 10 commits December 10, 2022 20:50

Refactor losing moves mapping

e0a8032

Add constant for draw score

59c7692

Add constant for win score

3da780b

Use new constants in move score function

7ac710d

Add draw moves mapping

1fe46e1

Add mapping of outcome to shapes mapping

7a78987

Use new mappings mapping

0577bd0

Reformat function definition

1a53dc3

Remove now unused outcome constants

1b5a254

Fix finding the desired shape

bc6f747

Previously the function gave the desired shape as if the given shape was ours and not the opponent's.

katzuv force-pushed the solve/2022-02 branch from 1195c53 to bc6f747 Compare December 10, 2022 19:47

Replace tuple items accessing with existing variables

de1feba

katzuv force-pushed the solve/2022-02 branch 3 times, most recently from 74812ad to 768d850 Compare December 10, 2022 20:06

Rename shapes.py to consts.py

8439278

This module contains now more constants than just shapes, so a name change is desired.

katzuv force-pushed the solve/2022-02 branch from 768d850 to 8439278 Compare December 10, 2022 20:07

katzuv requested a review from YoniKF December 23, 2022 15:06

YoniKF removed their request for review February 25, 2024 15:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solve 2022 day 02 #13

Solve 2022 day 02 #13

katzuv commented Dec 9, 2022

YoniKF left a comment

YoniKF Dec 10, 2022

katzuv Dec 10, 2022

YoniKF Dec 10, 2022

katzuv Dec 10, 2022

YoniKF Dec 10, 2022

katzuv commented Dec 10, 2022 •

edited

Loading

YoniKF Dec 10, 2022

YoniKF Dec 10, 2022

katzuv commented Dec 10, 2022

		import shapes


		DEFEAT = "X"

Solve 2022 day 02 #13

Are you sure you want to change the base?

Solve 2022 day 02 #13

Conversation

katzuv commented Dec 9, 2022

YoniKF left a comment

Choose a reason for hiding this comment

YoniKF Dec 10, 2022

Choose a reason for hiding this comment

katzuv Dec 10, 2022

Choose a reason for hiding this comment

YoniKF Dec 10, 2022

Choose a reason for hiding this comment

katzuv Dec 10, 2022

Choose a reason for hiding this comment

YoniKF Dec 10, 2022

Choose a reason for hiding this comment

katzuv commented Dec 10, 2022 • edited Loading

YoniKF Dec 10, 2022

Choose a reason for hiding this comment

YoniKF Dec 10, 2022

Choose a reason for hiding this comment

katzuv commented Dec 10, 2022

katzuv commented Dec 10, 2022 •

edited

Loading